[PATCH] D49273: [InstCombine] Expand the simplification of pow() involving exp{, 2}()
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Aug 19 06:33:40 PDT 2018
spatel added a comment.
This could still be split into 2 patches...
I'm just looking at the first code hunk, and I'm not sure this if this behaving as intended. We should have tests (please add) where both of the calls (exp{2}/pow) in the pattern are actual libcalls (rather than intrinsics). And in that case, this patch will replace a libcall with an intrinsic? Do the FMF allow that?
We should also have some test coverage for long double (fp128).
Repository:
rL LLVM
https://reviews.llvm.org/D49273
More information about the llvm-commits
mailing list