[PATCH] D49964: [DWARF] Refactor DWARF classes to use unified error reporting. NFC.

[Victor Leschuk via Phabricator via llvm-commits]

vleschuk marked 2 inline comments as done.
vleschuk added a comment.

In https://reviews.llvm.org/D49964#1186975, @jhenderson wrote:

> I just noticed that llvmObject has an `object_error` equivalent to std::errc, with a make_error_code method allowing us to turn them into std::error_code for use with the new function. In particular, there are unexpected_eof and parser_failed errors, which might be more appropriate for certain situations in this file. What do you think?


unexpected_eof is not very appropriate, when sections are too small I used illegal_byte_sequence. Maybe we could use parser_failed to replace some invalid_argument's. Let me check.


Repository:
  rL LLVM

https://reviews.llvm.org/D49964