[PATCH] D50944: [Hexagon] [Test] Remove undef and infinite loop from test

Dmytro Shynkevych via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 18 19:16:40 PDT 2018


hermord created this revision.
hermord added a reviewer: kparzysz.
Herald added a subscriber: llvm-commits.

As suggested in https://reviews.llvm.org/D50222, this has been refactored into a separate patch.

The undef and the infinite loop at the end cause this test to be translated unpredictably. In particular, the checked-for `mpy` disappears under certain legal optimizations (e.g. the one in https://reviews.llvm.org/D50222). Since the use of these constructs is not relevant to the behavior tested, according to the header comment, this change, suggested by @kparzysz, eliminates them.


Repository:
  rL LLVM

https://reviews.llvm.org/D50944

Files:
  test/CodeGen/Hexagon/swp-const-tc2.ll


Index: test/CodeGen/Hexagon/swp-const-tc2.ll
===================================================================
--- test/CodeGen/Hexagon/swp-const-tc2.ll
+++ test/CodeGen/Hexagon/swp-const-tc2.ll
@@ -9,14 +9,14 @@
 ; CHECK: = mpy
 ; CHECK-NOT: = mpy
 
-define void @f0() {
+define i32 @f0(i32* %a0) {
 b0:
   br label %b1
 
 b1:                                               ; preds = %b1, %b0
   %v0 = phi i32 [ 0, %b0 ], [ %v9, %b1 ]
   %v1 = phi i32 [ 0, %b0 ], [ %v8, %b1 ]
-  %v2 = load i32, i32* undef, align 4
+  %v2 = load i32, i32* %a0, align 4
   %v3 = add nsw i32 %v1, 1
   %v4 = srem i32 %v2, 3
   %v5 = icmp ne i32 %v4, 0
@@ -32,5 +32,5 @@
   br label %b3
 
 b3:                                               ; preds = %b3, %b2
-  br label %b3
+  ret i32 %v11
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50944.161385.patch
Type: text/x-patch
Size: 777 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180819/519c2709/attachment.bin>


More information about the llvm-commits mailing list