[PATCH] D50930: Move Itanium demangler implementation into a header file and add visitation support.

David L. Jones via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 17 17:57:18 PDT 2018


dlj accepted this revision.
dlj added a comment.
This revision is now accepted and ready to land.

Looks fine for my comments.



================
Comment at: include/llvm/Demangle/ItaniumDemangle.h:1973
+
+/// Visit the most-derived object corresponding to a node object.
+template<typename Fn>
----------------
Would it make sense to update this comment now that Expr is gone?

(I think this is what confused me about the ordering in FOR_EACH_NODE_KIND.)


Repository:
  rL LLVM

https://reviews.llvm.org/D50930





More information about the llvm-commits mailing list