[PATCH] D50930: Move Itanium demangler implementation into a header file and add visitation support.

[David L. Jones via Phabricator via llvm-commits]

dlj added inline comments.


================
Comment at: include/llvm/Demangle/ItaniumDemangle.h:29
 
-namespace {
+#define FOR_EACH_NODE_KIND(X) \
+    X(NodeArrayNode) \
----------------
Could you document the ordering semantics here?

I *think* it's most-to-least derived, but if I'm wrong... well, there you go. :-)


================
Comment at: include/llvm/Demangle/ItaniumDemangle.h:1121
 
 struct ForwardTemplateReference : Node {
   size_t Index;
----------------
Could you add an example of where this type appears?


================
Comment at: include/llvm/Demangle/ItaniumDemangle.h:1262
     case SpecialSubKind::allocator:
       S += "std::basic_string<char, std::char_traits<char>, "
            "std::allocator<char> >";
----------------
Isn't this just std::allocator? (Assuming it's for `Sa`)


Repository:
  rL LLVM

https://reviews.llvm.org/D50930