[PATCH] D50486: MachineScheduler: Refactor setPolicy() to limit computing remaining latency
Andrew Trick via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 17 14:45:16 PDT 2018
atrick added a comment.
Looks fine to me.
================
Comment at: lib/CodeGen/MachineScheduler.cpp:2429
+ unsigned &RemLatency) const {
+ if (CurrZone.getCurrCycle() > Rem.CriticalPath)
+ return true;
----------------
I suggest adding a brief comment here. I think this is just a quick check to bypass computeRemLatency, and ultimately we're trying to determine whether the current cycle plus remaining latency is greater than the critical path in the scheduling region.
Repository:
rL LLVM
https://reviews.llvm.org/D50486
More information about the llvm-commits
mailing list