[PATCH] D46179: [X86] Lowering addus/subus intrinsics to native IR (LLVM part)

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 17 14:22:14 PDT 2018

Previous message: [PATCH] D46179: [X86] Lowering addus/subus intrinsics to native IR (LLVM part)
Next message: [PATCH] D50443: [clang] Store code completion token range in preprocessor.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

craig.topper added a comment.

Turns out this patch only tested one of the two new paths added to X86ISelLowering.cpp. I've removed the detectAddSubSatPattern which contained the bug. I think we may want to put it back, but only with appropriate tests.


Repository:
  rL LLVM

https://reviews.llvm.org/D46179

Previous message: [PATCH] D46179: [X86] Lowering addus/subus intrinsics to native IR (LLVM part)
Next message: [PATCH] D50443: [clang] Store code completion token range in preprocessor.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list