[PATCH] D49678: [llvm-objcopy] Adding support for compressed DWARF debug sections.
Puyan Lotfi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 17 14:18:55 PDT 2018
plotfi marked 2 inline comments as done.
plotfi added inline comments.
================
Comment at: test/tools/llvm-objcopy/compress-debug-sections-zlib.test:18-19
+# CHECK-ZLIB: .debug_str
+# CHECK-ZLIB: 01000000 00000000 d0010000 00000000
+# CHECK-ZLIB: 01000000 00000000 789c4550
+
----------------
jhenderson wrote:
> plotfi wrote:
> > jhenderson wrote:
> > > I'm not sure what this is checking? Is it the contents?
> > Yes, the contents.
> Okay, so are the contents of the section important? I feel like this is something that could change relatively easily, if changes were made to zlib.
Good point. Removed it.
Repository:
rL LLVM
https://reviews.llvm.org/D49678
More information about the llvm-commits
mailing list