[PATCH] D50881: [ThinLTO] Add option for printing import failure reasons

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 17 09:07:46 PDT 2018


tejohnson marked 2 inline comments as done.
tejohnson added inline comments.


================
Comment at: include/llvm/Transforms/IPO/FunctionImport.h:44
+    None,
+    GlobalVar,
+    NotLive,
----------------
davidxl wrote:
> Add some comments on the reasons that are not obvious e.g, GlobalVar.
Went ahead and documented all.


================
Comment at: include/llvm/Transforms/IPO/FunctionImport.h:56
+    ValueInfo VI;
+    CalleeInfo::HotnessType MaxHotness;
+    ImportFailureReason Reason;
----------------
davidxl wrote:
> Add a comment on MaxHotness.
Went ahead and documented all.


Repository:
  rL LLVM

https://reviews.llvm.org/D50881





More information about the llvm-commits mailing list