[PATCH] D50886: [IR Verifier] Do not allow bitcast of pointer to vector of pointers and vice versa.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 17 02:33:56 PDT 2018


arsenm added inline comments.


================
Comment at: test/Verifier/bitcast-pointer-vector-neg.ll:7
+
+define <2 x i32*> @vector_illegal_bitcast_pointer_to_vector(i64* %a) {
+  %b = bitcast i64* %a to <2 x i32*>
----------------
Test names are misleading, these aren't pointers to vector


================
Comment at: test/Verifier/bitcast-pointer-vector-neg.ll:10
+  ret <2 x i32*> %b
+}
----------------
Should also include tests where the pointers are in a different address space with a different size (such that the total sizes match) for good measure


https://reviews.llvm.org/D50886





More information about the llvm-commits mailing list