[PATCH] D50828: Add profiling and canonicalization support to demangler nodes. No functionality change intended.

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 16 17:33:37 PDT 2018


zturner added a subscriber: rsmith.
zturner added a comment.

Another option is to simply move it into support and say that going forward
merges to libcxxabi might get more difficult. Perhaps this isn’t so bad
though. Isn’t the itanium demangler mostly complete? If the potential for
future changes to it is low, maybe this is an acceptable tradeoff. Then we
could just move it to support, use it and evolve it any way we want with no
restrictions, and when new functionality gets added to the itanium mangler
that needs to be port to libcxxabi, it’s a little more effort than a simple
copy paste because you have to think about it some.

Thoughts?


Repository:
  rL LLVM

https://reviews.llvm.org/D50828





More information about the llvm-commits mailing list