[PATCH] D49678: [llvm-objcopy] Adding support for compressed DWARF debug sections.

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 16 16:36:02 PDT 2018


alexshap added a comment.

Hi, I'm back from vacation and trying to catch up on all this stuff. 
I'm also interested in this feature since I have a few places where binutils objcopy is called with these flags.

After diving into the discussion here, it seems to me that the complexity stems from the fact, that we are trying to compress a section only if it actually makes things better.
To be honest, I didn't expect this behavior, not sure if we should follow it. 
If we do things differently, then (if I'm not mistaken) everything gets a bit simpler and can be done as follows (roughly speaking): introduce classes CompressedSection and DecompressedSection, then inside the Writer add the corresponding overloads to  handle these types of sections properly (and the Writer already knows the ELFT, consequently, there we have enough information to do it). @jakehehrlich , is it what you are saying or am I missing smth ?


Repository:
  rL LLVM

https://reviews.llvm.org/D49678





More information about the llvm-commits mailing list