[PATCH] D50875: Move lib/Demangle under lib/Support. No functionality change intended.

[Richard Smith - zygoloid via Phabricator via llvm-commits]

rsmith added a comment.

In https://reviews.llvm.org/D50875#1203443, @chandlerc wrote:

> In https://reviews.llvm.org/D50875#1203430, @rsmith wrote:
>
> > I did not remove the StringView.h from lib/Support/Demangle, because the `StringView` class has a different interface from both `llvm::StringRef` and `std::string_view`, and keeping that file around to provide the interface that the demangling code wants seems like the best path for now. (libc++abi presumably can't depend on `std::string_view`, so needs its own implementation anyway.)
>
>
> FWIW, I'd prefer that we make whatever libc++abi needs match the API of StringRef so that we can just have two modes for a single file, and leave the mini-StringRef-like thing in libc++abi....


I'm fine with that as a direction if the owners of the demangler are happy with it. I'd like to keep this particular patch focused on just the file moves, though. (Removing Compiler.h was cheap to do as part of the move because the interface was identical to that of the Support version.)


Repository:
  rL LLVM

https://reviews.llvm.org/D50875