[PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

[Raphael Isemann via Phabricator via llvm-commits]

teemperor added a comment.

@aleksandr.urakov Not sure if you are already working of this, but just FYI this patch introduced a few compiler warnings:

  /Users/teemperor/llvm/sidestuff/llvm/tools/lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:55:3: warning: default label in switch which covers all enumeration values [-Wcovered-switch-default]       
    default:                                                                                                                                                                                                 
    ^                                                                                                                                                                                                        
  /Users/teemperor/llvm/sidestuff/llvm/tools/lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:216:3: warning: default label in switch which covers all enumeration values [-Wcovered-switch-default]      
    default:                                                                                                                                                                                                 
    ^                                                                                                                                                                                                        
  /Users/teemperor/llvm/sidestuff/llvm/tools/lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:229:3: warning: default label in switch which covers all enumeration values [-Wcovered-switch-default]      
    default:                                                                                                                                                                                                 
    ^                                                                                                                                                                                                        
  3 warnings generated.
   20% [125/610] Building CXX object tools/lldb/source/Symbol/CMakeFiles/lldbSymbol.dir/ClangASTContext.cpp.o                                                                                               
  /Users/teemperor/llvm/sidestuff/llvm/tools/lldb/source/Symbol/ClangASTContext.cpp:6547:45: warning: comparison of integers of different signs: 'const int32_t' (aka 'const int') and 'unsigned int' [-Wsig$-compare]
                              if (base_offset != UINT32_MAX) {
                                  ~~~~~~~~~~~ ^  ~~~~~~~~~~
  /Users/teemperor/llvm/sidestuff/llvm/tools/lldb/source/Symbol/ClangASTContext.cpp:6760:34: warning: comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned int' [-Wsign-compare]  
                    if (bit_offset == UINT32_MAX)
                        ~~~~~~~~~~ ^  ~~~~~~~~~~
  2 warnings generated.


Repository:
  rL LLVM

https://reviews.llvm.org/D49980