[PATCH] D50828: Add profiling and canonicalization support to demangler nodes. No functionality change intended.

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

In https://reviews.llvm.org/D50828#1203412, @zturner wrote:

> But libc++abi doesn't include these headers.  It makes a copy of them and checks them in.  Does this solve that problem?


My understanding was that this macro would *allow* them to make that copy. They would copy the code, set the define, and not need a copy of Support.

We could of course insist that they do some kind of preprocessing of the source code as part of the copy, but not sure what that gains?

In https://reviews.llvm.org/D50828#1203413, @erik.pilkington wrote:

> In https://reviews.llvm.org/D50828#1203407, @chandlerc wrote:
>
> > libc++abi is under a different license than support.
> >
> > We can't fix this until at a minimum the relicensing is "done".
>
>
> Wait why? Do lawyers really care if we put this stuff in LLVMDemangle instead of LLVMSupport??


No, they care that libc++abi doesn't include code from Support which is under a different license.

If you want to move the file from one directory to another (without changing the code), maybe we can do that. But I don't think that discussion really needs to happen befor ethis change can be reviewed?


Repository:
  rL LLVM

https://reviews.llvm.org/D50828