[PATCH] D50330: [RFC] Implement out-of-process allocator enumeration for macOS

[Kostya Serebryany via Phabricator via llvm-commits]

kcc edited reviewers, added: morehouse; removed: alekseyshl.
kcc added a comment.

[sorry for delay, I've been OOO]
Ouch. That's really a lot of code in the core parts of *san, which adds quite a bit of maintenance tax. 
Two questions before we start reviewing the code:

- is it possible to move more of the logic into Mac-specific files?
- can other platforms benefit from this code in some way? How?



================
Comment at: lib/sanitizer_common/sanitizer_process_vm_reader.h:27
+struct ProcessVMReaderContext {
+#if SANITIZER_MAC
+  typedef task_t ProcessHandle;
----------------
is it possible to avoid #ifdefs in common code? 


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D50330