[PATCH] D48790: Update MemorySSA in Local utils removing blocks.

[Chijun Sima via Phabricator via llvm-commits]

NutshellySima accepted this revision.
NutshellySima added a comment.
This revision is now accepted and ready to land.

Thanks for the change.
Please have a look at my new inline comments. (I have a quick glance at the source code of MemorySSA and I think it's fine; but it's better for you to check that).
LGTM.



================
Comment at: lib/Transforms/Utils/Local.cpp:2240
+  if (MSSAU)
+    MSSAU->removeBlocks(DeadBlockSet);
+
----------------
We sometimes have BasicBlocks which are pending deletion in the `DomTreeUpdater`. (like that previously in `DeferredDominance`).

So, sometimes a same BasicBlock can be passed into `MSSAU->removeBlocks` multiple times in different calls to `removeUnreachableBlocks`. You need to be aware of that and check whether it is fine.


Repository:
  rL LLVM

https://reviews.llvm.org/D48790