[PATCH] D50784: [TableGen] Add Instruction custom byte sequence emission

[Artyom Goncharov via Phabricator via llvm-commits]

m4yers marked an inline comment as done.
m4yers added inline comments.


================
Comment at: utils/TableGen/CodeBeadsGen.cpp:13-14
+/// defined for an instruction. They are used to pass very target specific
+/// binary information directly from a tablegen file, e.g. instruction
+/// encoding.
+///
----------------
lebedev.ri wrote:
> Ignorant question: but surely the problem of storing instruction encoding in tablegen has already arose?
> How does this solution differ from the existing practice?
It allows to pass encoding strings of various length. Also it is semantically different from TSFlags and I thought it'd be a poor choice to extend its size and reuse.


Repository:
  rL LLVM

https://reviews.llvm.org/D50784