[PATCH] D50558: [MustExecute] Fix algorithmic bug in isGuaranteedToExecute. PR38514

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

LGTM

Thinking about it, I think it may be worth introducing a separate isGuaranteedToExecuteBeforeLoopExit with the old logic.  While LICM's hoisting logic needs the "must execute if loop entered" property, load store promotion actually only needs "store executes before any taken exits" property.  (We do need one "must execute" dereferencing instruction, but it doesn't have to be the store.)


https://reviews.llvm.org/D50558