[PATCH] D50765: [TargetLowering] Add support for non-uniform vectors to BuildSDIV

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

Thanks, looks almost NFC to me.



================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:3530-3531
+  auto BuildSDIVPattern = [&](ConstantSDNode *C) {
+    if (C->isNullValue())
+      return false;
+
----------------
We will end up with improperly-sized/indexed arrays.
I understand that `/ 0` is ub, but i wonder if we should be more proactive in failing?
Perhaps we should push `0, 0, 0` to the vectors. Or maybe the current way is sufficient.


Repository:
  rL LLVM

https://reviews.llvm.org/D50765