[PATCH] D41572: [MachineTraceMetrics] Fix bug in pickTracePred

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 16 07:42:21 PDT 2018

Previous message: [PATCH] D50260: [X86] Fix liveness information when expanding X86::EH_SjLj_LongJmp64
Next message: [PATCH] D50844: [RegisterCoalescer] Use substPhysReg in reMaterializeTrivialDef
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

thegameg added a comment.

Sorry, I'm afraid I can't help reviewing this patch as I know nothing about `MachineTraceMetrics`. Although, I suggest adding a test case, as it will help reviewers to understand better what the changes are.


https://reviews.llvm.org/D41572

Previous message: [PATCH] D50260: [X86] Fix liveness information when expanding X86::EH_SjLj_LongJmp64
Next message: [PATCH] D50844: [RegisterCoalescer] Use substPhysReg in reMaterializeTrivialDef
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list