[PATCH] D45653: [X86] Enable sibling-call optimization for functions returning structs

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 16 06:39:52 PDT 2018


lebedev.ri added a comment.

In https://reviews.llvm.org/D45653#1202370, @sorokin wrote:

> I made a C++ example for all 4 cases: sret/ptr function calls sret/ptr function.
>
> Here is the link: https://godbolt.org/g/FxUYvv
>
> I don't know if it is possible to make a ptr to sret function in pure C. I did this only in C++.


By C i meant anything that is not LLVM IR, so other compilers can be compared.
But, the results are not what i have hoped to see.
I kinda thought others were already doing this, and clang wasn't.
It does not look like it.
Or the C++ testcases are different from llvm ir, and we simply can't do this comparison.

So it seems we will need an ABI person after all :)


https://reviews.llvm.org/D45653





More information about the llvm-commits mailing list