[llvm] r339873 - [yaml2obj] - Allow to use numeric sh_link (Link) value for sections.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 16 05:44:17 PDT 2018


Author: grimar
Date: Thu Aug 16 05:44:17 2018
New Revision: 339873

URL: http://llvm.org/viewvc/llvm-project?rev=339873&view=rev
Log:
[yaml2obj] - Allow to use numeric sh_link (Link) value for sections.

That change allows using numeric values for Link field.
It is consistent with the code for another fields in this method.

Added:
    llvm/trunk/test/tools/yaml2obj/section-link.yaml
Modified:
    llvm/trunk/tools/yaml2obj/yaml2elf.cpp

Added: llvm/trunk/test/tools/yaml2obj/section-link.yaml
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/yaml2obj/section-link.yaml?rev=339873&view=auto
==============================================================================
--- llvm/trunk/test/tools/yaml2obj/section-link.yaml (added)
+++ llvm/trunk/test/tools/yaml2obj/section-link.yaml Thu Aug 16 05:44:17 2018
@@ -0,0 +1,25 @@
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-readobj -sections %t | FileCheck %s
+
+# CHECK:      Name: .text
+# CHECK-NEXT: Type: SHT_PROGBITS
+# CHECK-NEXT: Flags [
+# CHECK-NEXT:   SHF_ALLOC
+# CHECK-NEXT:   SHF_EXECINSTR
+# CHECK-NEXT: ]
+# CHECK-NEXT: Address:
+# CHECK-NEXT: Offset:
+# CHECK-NEXT: Size:
+# CHECK-NEXT: Link: 12345
+
+--- !ELF
+FileHeader:
+  Class:           ELFCLASS64
+  Data:            ELFDATA2LSB
+  Type:            ET_REL
+  Machine:         EM_X86_64
+Sections:
+  - Name:            .text
+    Type:            SHT_PROGBITS
+    Flags:           [ SHF_ALLOC, SHF_EXECINSTR ]
+    Link:            12345

Modified: llvm/trunk/tools/yaml2obj/yaml2elf.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/yaml2obj/yaml2elf.cpp?rev=339873&r1=339872&r2=339873&view=diff
==============================================================================
--- llvm/trunk/tools/yaml2obj/yaml2elf.cpp (original)
+++ llvm/trunk/tools/yaml2obj/yaml2elf.cpp Thu Aug 16 05:44:17 2018
@@ -245,7 +245,7 @@ bool ELFState<ELFT>::initSectionHeaders(
 
     if (!Sec->Link.empty()) {
       unsigned Index;
-      if (SN2I.lookup(Sec->Link, Index)) {
+      if (SN2I.lookup(Sec->Link, Index) && !to_integer(Sec->Link, Index)) {
         WithColor::error() << "Unknown section referenced: '" << Sec->Link
                            << "' at YAML section '" << Sec->Name << "'.\n";
         return false;




More information about the llvm-commits mailing list