[PATCH] D50589: [llvm-objcopy] Implement -G/--keep-global-symbol(s).

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

This LGTM. But maybe worth giving it a day or two to see if anybody responds to the email thread. Or you could commit it as is, and then fix things if people complain in the thread, I don't mind.



================
Comment at: test/tools/llvm-objcopy/keep-global-symbols-mix-globalize.test:43
+
+# CHECK:       Symbol {
+# CHECK-NEXT:    Name:
----------------
rupprecht wrote:
> jhenderson wrote:
> > I see what you're doing with this CHECK pattern, but I think it will false positive if we for some reason create additional symbols, although I guess I could be persuaded that this is not an issue to worry about.
> > 
> > I think you should probably also check the total symbol count. With that, I think this pattern becomes valid.
> I was actually able to get something much more terse/easier to check via FileCheck (and also has the symbol count) with -elf-output-style=GNU
Nice, I like it!


Repository:
  rL LLVM

https://reviews.llvm.org/D50589