[PATCH] D50243: [libunwind][mips] Include gcc_s for linkage
Stefan Maksimovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 16 02:12:47 PDT 2018
smaksimovic added a comment.
@joerg Would it be okay to commit this?
The LIBUNWIND_HAS_GCC_S_LIB although declared, did not have its value used anywhere unlike LIBUNWIND_HAS_C_LIB and LIBUNWIND_HAS_DL_LIB which had been declared/used similarly.
The added line is only executed if the following block is (`cmake/config-ix.cmake`):
if (NOT LIBUNWIND_USE_COMPILER_RT)
check_library_exists(gcc_s __gcc_personality_v0 "" LIBUNWIND_HAS_GCC_S_LIB)
endif()
in which case compiler-rt is not being used anyway, if that's what you were referring to.
https://reviews.llvm.org/D50243
More information about the llvm-commits
mailing list