[PATCH] D50213: DebugInfo: Add metadata support for disabling DWARF pub sections
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 15 13:27:49 PDT 2018
aprantl added a comment.
>> Can you add a bitcode upgrade test?
>
> I could - but I'm not sure it would test anything. The format has in some sense remained the same - this field is still zero/one before/after the change, but now new values are also valid.
> Reckon it's still worth testing? What do you reckon that testing would cover?
It would be sufficient to find an existing .bc file with a DICompileUnit in it and add a CHECK: that tests that the new flag comes out as default(=0) (which probably means it won't be printed at all, but that's fine).
Repository:
rL LLVM
https://reviews.llvm.org/D50213
More information about the llvm-commits
mailing list