[PATCH] D49879: [PowerPC] Generate Power9 extswsli extend sign and shift immediate instruction

Roland Froese via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 15 12:00:17 PDT 2018


RolandF added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:14118
+      N0.getOperand(0).getValueType() != MVT::i32 ||
+      CN1 == NULL)
+    return SDValue();
----------------
nemanjai wrote:
> Nit: please change `CN1 == NULL` to either `!CN1` or `CN1 == nullptr`. Feel free to do this on the commit - no new review required.
Sorry, I don't have commit access, so I have updated the diff.


https://reviews.llvm.org/D49879





More information about the llvm-commits mailing list