[PATCH] D50658: Hot cold splitting pass

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya added a comment.

In https://reviews.llvm.org/D50658#1200708, @kparzysz wrote:

> This looks good.  Do you have a testcase that demonstrates what this pass does?


Working on it.



================
Comment at: lib/Transforms/IPO/HotColdSplitting.cpp:209
+      // Get cold region
+      BasicBlock *Exit = PDT[BB]->getIDom()->getBlock();
+      SmallVector<BasicBlock *, 4> Region;
----------------
kparzysz wrote:
> Another thing for the future development would be to find the largest cold section of the code: for example, if there are two adjacent loops that are both in a cold side of an if-statement, both of them could be outlined into the same function.
That's a good idea! Thanks. I'll work on that. Another improvement I'm thinking of is to outline multiple regions from a function.


https://reviews.llvm.org/D50658