[PATCH] D45653: [X86] Enable sibling-call optimization for functions returning structs

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In https://reviews.llvm.org/D45653#1200806, @aleksandr.urakov wrote:

> @spatel Excuse me, can you explain, please, what's wrong with this patch now?
>
> Ivan is my colleague, he have asked me to solve this review a week ago. And he have mentioned here, that he doesn't mind if someone will comandeer the review...
>
> There was the very long delay with a reply, and I understand that it's not good (and I'm very sorry for that really). But now I want to solve this in the nearest future.
>
> I really hope for your understanding.


Sorry - I didn't mean to imply that the patch was wrong in any way by resigning as reviewer. I did that only because I don't know enough to review the patch! The test changes certainly look like wins.
As I said earlier, I'm hoping that someone with access to the Radar bug that motivated the existing code can comment. If not, then someone who knows more about the calling conventions should have a look (but I'm not sure who else to add as a potential reviewer).


https://reviews.llvm.org/D45653