[PATCH] D50776: [yaml2obj] - Teach yaml2obj to produce SHT_GROUP section with a custom Info field.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 15 06:48:51 PDT 2018


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with nit.



================
Comment at: test/tools/yaml2obj/elf-comdat-broken2.yaml:1
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-readobj -sections %t | FileCheck %s
----------------
Maybe worth calling this broken-info rather than broken2, to be more descriptive.


================
Comment at: test/tools/yaml2obj/elf-comdat-broken2.yaml:18
+
+## Check we are able to produce SHT_GROUP section with a custom Info (12345).
+# CHECK:      Name: .group
----------------
Nit: with a custom Info value


https://reviews.llvm.org/D50776





More information about the llvm-commits mailing list