[PATCH] D50648: [SystemZ] Enable trackSubRegLiveness

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 15 06:15:47 PDT 2018


jonpa added a comment.

Thanks again for working on this :-)

With your latest fixes applied (including the subregindex patch), I could see just one more test failure from last night, which I uploaded on Bugzilla.

Maybe it would be a good idea to have an option in the SystemZ enableSubRegLiveness() method that enables subreg liveness which (at least initially) defaults to off, so that you can commit your fixes with test cases for SystemZ? Perhaps some word of caution like "experimental" could be used somewhere...?

I don't think FileCheck is needed to check for successful compilation. For instance test/CodeGen/SystemZ/dag-combine-04.ll just runs llc and the comment explains what is supposed not to crash.

The tc_... naming are probably not ideal for SystemZ tests, sorry. subregliveness-01.ll, subregliveness-02.ll, ... are probably better names.


Repository:
  rL LLVM

https://reviews.llvm.org/D50648





More information about the llvm-commits mailing list