[PATCH] D45653: [X86] Enable sibling-call optimization for functions returning structs
Aleksandr Urakov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 15 04:50:46 PDT 2018
aleksandr.urakov marked an inline comment as done.
aleksandr.urakov added inline comments.
================
Comment at: test/CodeGen/X86/sibcall.ll:661-664
; 32-LABEL: t21_non_sret_to_sret:
; 32: jmp {{_?}}t21_f_sret
; 64-LABEL: t21_non_sret_to_sret:
; 64: jmp {{_?}}t21_f_sret
----------------
lebedev.ri wrote:
> Hm, this looks wrong. There is no such check prefixes on the run lines (at the beginning of the file)
> Did you use `utils/update_llc_test_checks.py`?
Yes, I use this utility, but it doesn't delete these lines. They must've be left here since the first version of the patch and are treated as simple comments. I'll update this.
https://reviews.llvm.org/D45653
More information about the llvm-commits
mailing list