[PATCH] D50761: [yaml2obj] - Teach tool to produce SHT_GROUP section with a custom type.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 15 04:42:46 PDT 2018

Previous message: [PATCH] D50761: [yaml2obj] - Teach tool to produce SHT_GROUP section with a custom type.
Next message: [PATCH] D50761: [yaml2obj] - Teach tool to produce SHT_GROUP section with a custom type.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

grimar added a comment.

Thanks for the review, James!



================
Comment at: test/tools/yaml2obj/elf-comdat-broken.yaml:17
+      - SectionOrType: 0xFF
+      - SectionOrType: 0x3
+Symbols:
----------------
jhenderson wrote:
> Maybe you should make this a decimal?
Yep.


https://reviews.llvm.org/D50761

Previous message: [PATCH] D50761: [yaml2obj] - Teach tool to produce SHT_GROUP section with a custom type.
Next message: [PATCH] D50761: [yaml2obj] - Teach tool to produce SHT_GROUP section with a custom type.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list