[PATCH] D50761: [yaml2obj] - Teach tool to produce SHT_GROUP section with a custom type.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with nit. I guess if somebody wants decimal support later, they can add it then.



================
Comment at: test/tools/yaml2obj/elf-comdat-broken.yaml:6-20
+  Class:           ELFCLASS64
+  Data:            ELFDATA2LSB
+  Type:            ET_REL
+  Machine:         EM_X86_64
+Sections:
+  - Name:            .group
+    Type:            SHT_GROUP
----------------
Nit: There's an awful lot of extra (and inconsistent) whitespace between the field names and values. It would be nice to make it more consistent (either only a single space, or for all the blocks to be indented to a minimum level such that they all line up with each other e.g:
```
  Class:   ELFCLASS64
  Data:    ELFDATA2LSB
  Type:    ET_REL
  Machine: EM_X86_64
```


https://reviews.llvm.org/D50761