[PATCH] D50343: [llvm-objcopy] Add support for -I binary -B <arch>.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 15 02:22:58 PDT 2018
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, but there is one thing still outstanding, I think, which @jakehehrlich mentioned in a comment regarding the CopyConfig options:
> A pattern of grouping by type does seem to have formed organically however. Let's stick with it.
I don't have a strong preference either way, but you should get @jakehehrlich to confirm he is happy before committing this change.
Repository:
rL LLVM
https://reviews.llvm.org/D50343
More information about the llvm-commits
mailing list