[PATCH] D50749: [MemorySSA] Expose the verify as a debug option.

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

LGTM with a few comments. Thanks!



================
Comment at: lib/Analysis/MemorySSA.cpp:80
 
-static cl::opt<bool>
-    VerifyMemorySSA("verify-memoryssa", cl::init(false), cl::Hidden,
-                    cl::desc("Verify MemorySSA in legacy printer pass."));
+bool llvm::VerifyMemorySSA = false;
+static cl::opt<bool, true>
----------------
Do we want to enable this by default if EXPENSIVE_CHECKS is on? Looks like the other verify* are auto-enabled (at least to some extent) in that case, and the comment above them says so.

(I'm happy in either case. I just want reasoning to point to if the answer is "we shouldn't, because ...." )


================
Comment at: lib/Analysis/MemorySSA.cpp:83
+    VerifyMemorySSAX("verify-memoryssa", cl::location(VerifyMemorySSA),
+                     cl::Hidden, cl::desc("Enable verify of MemorySSA."));
 
----------------
s/verify/verification/


Repository:
  rL LLVM

https://reviews.llvm.org/D50749