[PATCH] D48273: [WebAssembly] CFG stackify support for exception handling

[Derek Schuff via Phabricator via llvm-commits]

dschuff added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp:443
+  // Compute the nearest common dominator of all unwind predecessors
+  MachineBasicBlock *Header = nullptr;
+  int MBBNumber = MBB.getNumber();
----------------
The fact that so many sections of this function are the same as or almost the same as `placeBlockMarker` kind of makes me wonder if we can do better about sharing the logic, although there are enough differences to make that challenging too. Probably worth thinking about, especially if we end up thinking of going toward a more explicit or IR-like representation of wasm control structures.


Repository:
  rL LLVM

https://reviews.llvm.org/D48273