[PATCH] D50419: [ELF] Skip non-InputSection's in getErrPlace

[Fangrui Song via Phabricator via llvm-commits]

MaskRay abandoned this revision.
MaskRay added a comment.

In https://reviews.llvm.org/D50419#1198702, @grimar wrote:

> It seems caused by https://reviews.llvm.org/rL336106. But I really do not understand how it can happen.
>
> As my comment for the commit says:
>  "We should only have InputSection type of the sections in the vector.
>  (because we already converted MergeInputSection in mergeSections()
>  and combined EhInputSections in combineEhFrameSections())."
>
> What am I missing?


Thanks for the information! I find that `mergeSections()` does not remove non-alive sections as its comments says. I have created https://reviews.llvm.org/D50742

In an internal target, both revisions will fix the invalid cast but https://reviews.llvm.org/D50742 is obviously the way to go.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50419