[PATCH] D45151: [LICM] Hoisting invariant.group loads

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 14 15:46:40 PDT 2018


sanjoy added a comment.

I'm sorry I can't be more decisive here since I wasn't deeply involved with the devirtualization work early on and so lack a lot of context.  The general direction here seems fine to me -- given that we use metadata to express a large range of things, it seems ok to have metadata specific MD dropping policies.  However, given that Hal originally objected to this, we should make sure he is on board.


Repository:
  rL LLVM

https://reviews.llvm.org/D45151





More information about the llvm-commits mailing list