[PATCH] D48879: [XRay][test-suite] Benchmarks for profiling mode implementation

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added a comment.

In https://reviews.llvm.org/D48879#1199118, @hans wrote:

> In https://reviews.llvm.org/D48879#1199017, @dberris wrote:
>
> > I could reproduce locally, and so I had a look but this time I needed to rebuild on a clean build dir. PTAL?
>
>
> I ran "make clean" on it and tried again, but with the same result


I found that 'make clean' doesn't quite cut it unfortunately, I needed to have a full clean build -- I suspect this is because the lit config is copied/cached when building/running the tests?

Either that or the version that's in 7.0 doesn't have some recent changes to profiling mode. I have been testing with the latest from trunk.

> It does produce some output before segfaulting, if that's any help:
> 
>   name,iterations,real_time,cpu_time,time_unit,bytes_per_second,items_per_second,label,error_occurred,error_message
>   "BM_XRayProfilingShallowStack/real_time/threads:1",5061883,144.624,134.259,ns,,,,,
>   "BM_XRayProfilingShallowStack/real_time/threads:2",6094380,94.531,179.154,ns,,,,,

That's a little helpful, but not much -- I was using virtualenv as well locally, but after a full re-build/re-configure I couldn't reproduce the failures. :/


Repository:
  rT test-suite

https://reviews.llvm.org/D48879