[PATCH] D50717: [NFC][SimplifyCFG] Remove pointer from SmallPtrSet before deletion

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 14 09:55:34 PDT 2018


kuhar added a comment.

In https://reviews.llvm.org/D50717#1199198, @dmgreen wrote:

> I guess because it's only erasing it from a SmallPtrSet, it's not actually _using_ it, but this looks like a very sensible change.


I thought that erase calls delete on the link list node which invalidates the node itself but also the pointer, doesn't it?


Repository:
  rL LLVM

https://reviews.llvm.org/D50717





More information about the llvm-commits mailing list