[PATCH] D50698: [UnJ] Ensure unroll_and_jam metadata is removed once consumed.

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya added inline comments.


================
Comment at: include/llvm/Analysis/LoopInfo.h:568
   /// unrolling pass is run more than once (which it generally is).
-  void setLoopAlreadyUnrolled();
+  void setLoopAlreadyUnrolled(StringRef Prefix = "llvm.loop.unroll.");
 
----------------
I think we can add the Prefix at the caller all the time, a default value of "llvm.loop.unroll." may not be general. It seems renaming the function to reflect a more general semantics like: setLoopAlreadyTransformed and then renaming appropriate local variables would be a good improvement.


https://reviews.llvm.org/D50698