[PATCH] D49281: [Unroll/UnrollAndJam/Vectorizer/Distribute] Add followup loop attributes.

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:1101
+    Optional<MDNode *> RemainderLoopID =
+        makeFollowupLoopID(OrigLoopID, {"llvm.loop.unroll.followup_all",
+                                        "llvm.loop.unroll.followup_remainder"});
----------------
nit: maybe put the string literals as a separate declaration?


================
Comment at: lib/Transforms/Utils/LoopUnrollRuntime.cpp:543
+                                      AssumptionCache *AC, bool PreserveLCSSA,
+                                      Loop **ResultLoop) {
   LLVM_DEBUG(dbgs() << "Trying runtime unrolling on Loop: \n");
----------------
What is the rationale of using pointer to a pointer here? If we want to assign to ResultLoop, then maybe we can just return ResultLoop and bool as a pair.


================
Comment at: lib/Transforms/Utils/LoopUnrollRuntime.cpp:912
 
+  auto UnrollResult = LoopUnrollResult ::Unmodified;
   if (remainderLoop && UnrollRemainder) {
----------------
nit: space


Repository:
  rL LLVM

https://reviews.llvm.org/D49281