[PATCH] D50401: [GISel]: Add Opcodes for a few Libm Intrinsics

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 14 04:59:10 PDT 2018


aemerson added inline comments.


================
Comment at: include/llvm/Target/GenericOpcodes.td:516
+//------------------------------------------------------------------------------
+// LIBM Intrinsics
+//------------------------------------------------------------------------------
----------------
arsenm wrote:
> aditya_nandakumar wrote:
> > aemerson wrote:
> > > Perhaps say "LIBM compatible intrinsics"
> > Would you name it G_FTRUNC? I thought that is very similar to G_FPTRUNC and might lead to confusion. One other name I can think of is G_INTRINSIC_TRUNC which makes it explicit that this is the intrinsic equivalent in llvm IR. 
> Yes
Matt can you clarify which of those two suggestions you meant? Aditya named the intrinsics G_INTRINSIC_TRUNC but did you mean we should name them G_FTRUNC?


https://reviews.llvm.org/D50401





More information about the llvm-commits mailing list