[PATCH] D50687: [GraphDiff] Make InverseGraph a property of a GraphDiff.

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 13 22:56:25 PDT 2018


asbirlea created this revision.
asbirlea added reviewers: timshen, kuhar.
Herald added subscribers: jlebar, sanjoy.

Treating a graph in reverse is a property of the GraphDiff and should instead be a template argument, just like IsPostDom is one for DomTrees.
If it's just an argument to all methods, we could have mismatches between the constructor of the GraphDiff which may reverse the updates when filtering them, and the calls retrieving the filtered delete/insert updates.
Also, since this will be used in IDF, where we're using a DomTree, this creates a cleaner interface for the GraphTraits to use the existing template argument of DomTreeBase.

Separate patch from the one adding GraphDiff, so get a clear diff of what changed.


Repository:
  rL LLVM

https://reviews.llvm.org/D50687

Files:
  include/llvm/IR/CFGDiff.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50687.160514.patch
Type: text/x-patch
Size: 5651 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180814/2a092137/attachment.bin>


More information about the llvm-commits mailing list