[PATCH] D50680: [SDAG] Remove the reliance on MI's allocation strategy for `MachineMemOperand` pointers attached to `MachineSDNodes` and instead have the `SelectionDAG` fully manage the memory for this array.

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 13 17:40:26 PDT 2018


hfinkel added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/SelectionDAGNodes.h:2256
 
-  /// Memory reference descriptions for this instruction.
-  mmo_iterator MemRefs = nullptr;
-  mmo_iterator MemRefsEnd = nullptr;
+  PointerUnion<MachineMemOperand *, MachineMemOperand **> MemRefs = {};
+
----------------
Should we use TinyPtrVector here instead of making this PointerUnion and keeping NumMemRefs below?


Repository:
  rL LLVM

https://reviews.llvm.org/D50680





More information about the llvm-commits mailing list