[PATCH] D50671: [DomTree] Add constructor to create a new DT based on current DT/CFG and a set of Updates.

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added a comment.

Looks fine.



================
Comment at: include/llvm/Support/GenericDomTree.h:737
 
+  void recalculate(ParentPtr Func, ArrayRef<UpdateType> Updates) {
+    Parent = Func;
----------------
I think it would be better to take parent function by reference/pointer consistently. Reference implies non-null, which seems better here.


Repository:
  rL LLVM

https://reviews.llvm.org/D50671