[PATCH] D50671: [DomTree] Add constructor to create a new DT based on current DT/CFG and a set of Updates.

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added inline comments.


================
Comment at: include/llvm/IR/Dominators.h:49
 extern template void Calculate<BBDomTree>(BBDomTree &DT);
+extern template void CalculateNewDT<BBDomTree>(BBDomTree &DT, BBUpdates U);
+
----------------
How about `CalculateWithUpdates`? CalculateNew is not the most informative in my opinion.


================
Comment at: lib/IR/Dominators.cpp:79
     DomTreeBuilder::BBPostDomTree &DT);
+// No CalculateNewDT<PostDomTree> instantiation, unless usecase arises.
 
----------------
nit: `a usecase` ?


Repository:
  rL LLVM

https://reviews.llvm.org/D50671