[PATCH] D50675: [IDF] Teach Iterated Dominance Frontier to use a snapshot CFG based on a GraphDiff.

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added inline comments.


================
Comment at: lib/Analysis/IteratedDominanceFrontier.cpp:93
+          for (auto Pair :
+               children<std::pair<const GraphDiff<BasicBlock *> *, NodeTy>>(
+                   {GD, BB}))
----------------
Is it possible to instead create a helper function in GraffDiff that returns a node of appropriate type (like the pair here)?
Something like `children(GraphDiff::make_node(GD, BB))`


================
Comment at: lib/Analysis/IteratedDominanceFrontier.cpp:101
+            doWork(Pair.second);
+      } else
+        for (auto *Succ : children<NodeTy>(BB))
----------------
I'd prefer braces around the for


Repository:
  rL LLVM

https://reviews.llvm.org/D50675