[PATCH] D50479: Expose CFG Update struct. Define GraphTraits to get children given a snapshot CFG.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea marked an inline comment as done.
asbirlea added inline comments.


================
Comment at: include/llvm/Support/CFGUpdate.h:105
+             [&Operations](const Update<NodePtr> &A, const Update<NodePtr> &B) {
+               return Operations[{A.getFrom(), A.getTo()}] >
+                      Operations[{B.getFrom(), B.getTo()}];
----------------
timshen wrote:
> Just want to make sure that this sorts to descending order.
Yes, that's right. The reason is that DomTree then applies updates from the end of the vector, so they will be applied in the original order.

My use case of GraphDiff does not care about update order and I don't want to change the order for DomTree, so I'll leave it like this in this patch.
I'm planning to refactor DomTree to use GraphDiff instead of its inner data structure (BatchUpdaterInfo), so then I can tell DT to use the Updates in order, and also reverse the sort here.


Repository:
  rL LLVM

https://reviews.llvm.org/D50479